🐛(frontend) Interlinking memory leak #1560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
added
bug
AntoLC
force-pushed
the
fix/interlinking-memory-leak
branch
from
e389602 to
abd575a
Compare
|
Size Change: +4.19 kB (+0.11%) Total Size: 3.68 MB
|
lunika
approved these changes
Nov 5, 2025
We can now unsubscribe on the editor events, improving performance and preventing memory leaks.
When doing collaborative editing, doc?.title might be out of sync for other users when updated by another user. This causes the useEffect to run repeatedly, causing an infinite loop of updates. We now trigger the effect only when doc?.title changes, not when the customInlineContent changes.
Catch and log errors when replacing blocks during file upload.
AntoLC
force-pushed
the
fix/interlinking-memory-leak
branch
from
abd575a to
f9ff578
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When investigating about a memory leak during collaboration we found a problem with the interlinking that could cause a memory leak.
When doing collaborative editing,
doc?.titlemight be out of sync for other users when updated by another user.This can cause a useEffect to run repeatedly, causing an infinite loop of updates.
We now trigger the effect only when doc?.title changes, not when the customInlineContent changes.
Proposal