-
Notifications
You must be signed in to change notification settings - Fork 446
✨(frontend) enable ODT export for documents #1524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
47a5216 to
5285d3b
Compare
5285d3b to
59bacbd
Compare
provides ODT export with support for callout, upload, interlinking and tests Signed-off-by: Cyril <[email protected]> ✨(frontend) add image and interlinking support for odt export Added image mapping with SVG conversion and clickable document links. Signed-off-by: Cyril <[email protected]> ✅(e2e) add e2e tests for odt export and interlinking features covers odt document export and cross-section interlinking use cases Signed-off-by: Cyril <[email protected]> ✨(odt) add generic helper and style callout block for odt export create odtRegisterParagraphStyleForBlock and apply background/padding styles Signed-off-by: Cyril <[email protected]>
59bacbd to
7cac499
Compare
|
Size Change: +389 kB (+10.56%) Total Size: 4.07 MB
|
|
🚀 Preview will be available at https://1524-docs.ppr-docs.beta.numerique.gouv.fr/ You can use the existing account with these credentials:
You can also create a new account if you want to. Once this Pull Request is merged, the preview will be destroyed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work well, bravo !
| "@blocknote/react": "0.41.1", | ||
| "@blocknote/xl-docx-exporter": "0.41.1", | ||
| "@blocknote/xl-multi-column": "0.41.1", | ||
| "@blocknote/xl-odt-exporter": "^0.41.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "@blocknote/xl-odt-exporter": "^0.41.1", | |
| "@blocknote/xl-odt-exporter": "0.41.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get local changes in the yarn.lock, I don't think it is updated correctly.
| { | ||
| 'xlink:type': 'simple', | ||
| 'text:style-name': 'Internet_20_link', | ||
| 'office:target-frame-name': '_top', | ||
| 'xlink:show': 'replace', | ||
| 'xlink:href': url, | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We get warning in the console, what about this way ?
| { | |
| 'xlink:type': 'simple', | |
| 'text:style-name': 'Internet_20_link', | |
| 'office:target-frame-name': '_top', | |
| 'xlink:show': 'replace', | |
| 'xlink:href': url, | |
| }, | |
| { | |
| xlinkType: 'simple', | |
| 'text:style-name': 'Internet_20_link', | |
| 'office:target-frame-name': '_top', | |
| xlinkShow: 'replace', | |
| xlinkHref: url, | |
| }, |
| { | ||
| 'xlink:type': 'simple', | ||
| 'xlink:show': 'embed', | ||
| 'xlink:actuate': 'onLoad', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We get warning in the console:
| 'xlink:actuate': 'onLoad', | |
| xlinkActuate: 'onLoad', |
| { | ||
| 'text:style-name': | ||
| block.props.textAlignment === 'center' | ||
| ? 'center' | ||
| : block.props.textAlignment === 'right' | ||
| ? 'right' | ||
| : 'left', | ||
| }, | ||
| React.createElement( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Images seems everytime centered, same with svg btw.
Purpose
Make ODT export available, including support for necessary frontend blocks and features.
issue 487
exportODT.mov
Proposal