🐛(frontend) fix attachment download filename #1447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
fix/1413-correct-download-attachments-name
branch
from
616011c to
736c76a
Compare
|
Size Change: +52 B (0%) Total Size: 3.66 MB
|
Ovgodd
force-pushed
the
fix/1413-correct-download-attachments-name
branch
from
736c76a to
483730e
Compare
Ovgodd
force-pushed
the
fix/1413-correct-download-attachments-name
branch
5 times, most recently
from
aa5294a to
bb41aa1
Compare
AntoLC
reviewed
Oct 3, 2025
Comment on lines
90
to
93
| const unsafeName = baseName.includes('.') | ||
| ? baseName.replace(/(\.[^/.]+)$/, '-unsafe$1') | ||
| : baseName + '-unsafe'; |
There was a problem hiding this comment.
Suggested change
| const unsafeName = baseName.includes('.') | |
| ? baseName.replace(/(\.[^/.]+)$/, '-unsafe$1') | |
| : baseName + '-unsafe'; | |
| const regFindLastDot = /(\.[^/.]+)$/; | |
| const unsafeName = baseName.includes('.') | |
| ? baseName.replace(regFindLastDot, '-unsafe$1') | |
| : baseName + '-unsafe'; |
Comment on lines
904
to
877
| await page.locator('.bn-block-content[data-content-type="pdf"]').click(); | ||
|
|
||
| await page.locator('[data-test="downloadfile"]').click(); | ||
|
|
||
| const download = await downloadPromise; | ||
| expect(download.suggestedFilename()).toBe('test-pdf.pdf'); | ||
| }); |
There was a problem hiding this comment.
Maybe not necessary to create a new test, could you maybe add this part in the test above (it embeds PDF) ?
Oh that's great 👍 ! |
Ovgodd
force-pushed
the
fix/1413-correct-download-attachments-name
branch
from
c22b84b to
3e32128
Compare
Ovgodd
force-pushed
the
fix/1413-correct-download-attachments-name
branch
2 times, most recently
from
0f90312 to
504109a
Compare
AntoLC
approved these changes
Oct 6, 2025
Ovgodd
force-pushed
the
fix/1413-correct-download-attachments-name
branch
from
504109a to
cf3d526
Compare
use the document title instead of the uuid when downloading attachments Signed-off-by: Cyril <[email protected]>
Add no-unnecessary-type-assertion rule to eslint config to avoid automatically unnecessary type assertions in the codebase.
Ovgodd
force-pushed
the
fix/1413-correct-download-attachments-name
branch
from
cf3d526 to
236c8df
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the filename used when downloading an attachment. Previously, the file was downloaded with its UUID, which was not user-friendly.
issue : 1413
Proposal