Skip to content

✨(frontend) exclude h4-h6 headings from table of contents #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2025
Merged

✨(frontend) exclude h4-h6 headings from table of contents #1441

merged 1 commit into from
Oct 6, 2025

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Oct 1, 2025 •
edited
Loading

Purpose

Fix the document outline behavior where h4 to h6 headings were incorrectly considered as higher-level (similar to h1).
This caused the table of contents to display misleading hierarchy and confused navigation.

issue : 1435

Proposal

  • Exclude h4 to h6 headings from the generated table of contents

@Ovgodd Ovgodd self-assigned this Oct 1, 2025
@Ovgodd Ovgodd added bug Something isn't working frontend labels Oct 1, 2025
@Ovgodd Ovgodd force-pushed the fix/1435-ignore-h4-h6-outline branch from e91c1e2 to e842ae8 Compare October 1, 2025 07:52
@github-actions
Copy link

github-actions bot commented Oct 1, 2025 •
edited
Loading

Size Change: +33 B (0%)

Total Size: 3.66 MB

Filename Size Change
apps/impress/out/_next/static/c20b463f/_buildManifest.js 0 B -864 B (removed) 🏆
apps/impress/out/_next/static/09a6d3fd/_buildManifest.js 863 B +863 B (new file) 🆕

compressed-size-action

@Ovgodd Ovgodd requested a review from AntoLC October 1, 2025 08:57
@Ovgodd Ovgodd marked this pull request as ready for review October 1, 2025 08:57
AntoLC
AntoLC reviewed Oct 2, 2025
View reviewed changes
src/frontend/apps/impress/src/features/docs/doc-table-content/components/TableContent.tsx
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you should do the filter here, but here instead:

docs/src/frontend/apps/impress/src/features/docs/doc-editor/stores/useHeadingStore.tsx

Line 32 in e842ae8

.filter((block) => block.type === 'heading')

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed, thank you

@Ovgodd Ovgodd requested a review from AntoLC October 2, 2025 11:23
@AntoLC AntoLC linked an issue Oct 3, 2025 that may be closed by this pull request
Ignore h4 to h6 headers in document outline (or properly indent them) #1435
Closed
@Ovgodd Ovgodd force-pushed the fix/1435-ignore-h4-h6-outline branch 2 times, most recently from e432460 to cc38b38 Compare October 6, 2025 09:25
@Ovgodd
✨(frontend) exclude h4-h6 headings from table of contents
431c331 
filters out h4-h6 so they no longer appear in the document outline

Signed-off-by: Cyril <[email protected]>
@Ovgodd Ovgodd force-pushed the fix/1435-ignore-h4-h6-outline branch from cc38b38 to 431c331 Compare October 6, 2025 09:28
@Ovgodd Ovgodd merged commit 431c331 into main Oct 6, 2025
21 of 22 checks passed
@Ovgodd Ovgodd deleted the fix/1435-ignore-h4-h6-outline branch October 6, 2025 10:15
@AntoLC AntoLC mentioned this pull request Oct 14, 2025
Merged
@AntoLC AntoLC mentioned this pull request Oct 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AntoLC AntoLC AntoLC approved these changes

Assignees

@Ovgodd Ovgodd

Labels

bug Something isn't working frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ignore h4 to h6 headers in document outline (or properly indent them)

2 participants

@Ovgodd @AntoLC