🐛(frontend) include root parent in search #1243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
fix/include-top-parent-search
branch
from
7613e6b to
e527f91
Compare
Ovgodd
requested changes
Jul 30, 2025
| const subDocs = subDocsData?.pages.flatMap((page) => page.results) || []; | ||
|
|
||
| if ( | ||
| treeContext?.root && |
There was a problem hiding this comment.
If I may suggest, wrapping this condition in a variable could improve readability, little exemple :
const rootDoc = treeContext?.root;
const shouldIncludeRootInResults =
!!rootDoc && rootDoc.title?.toLowerCase().includes(search.toLowerCase());
Suggested change
| treeContext?.root && | |
| if (shouldIncludeRootInResults) { | |
| subDocs.unshift(rootDoc); | |
| } | |
lunika
approved these changes
Jul 30, 2025
When searching for documents, the root parent document is now included in the search results if it matches the search query.
AntoLC
force-pushed
the
fix/include-top-parent-search
branch
from
e527f91 to
30dfea7
Compare
Ovgodd
approved these changes
Jul 30, 2025
This was referenced Jul 30, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The root parent was not included in the search.
Proposal
When searching for documents, the root parent document is now included in the search results if it matches the search query.