Skip to content

Improve code readability and avoid "over" accessibility #1401

@cyberbaloo

Description

@cyberbaloo

Feature Request

Is your feature request related to a problem or unsupported use case? Please describe.
I've noticed that sometimes there is "over-accessibility." In this example, the button already has an explicit label. It's not necessary to specify it again in the aria-label attribute

Describe the solution you'd like

The code before

<button role="menuitem" aria-label="Historique des versions" class="sc-34780e96-0 jAUuhJ --docs--box-button ">
<div class="sc-34780e96-0 jwbyrB">
<span class="sc-34780e96-0 sc-262648e5-0 iiwUsF gukRvY --docs--icon-bg material-icons" aria-hidden="true">history</span>
<span class="sc-34780e96-0 sc-262648e5-0 iiwUsF dxYzTI">Historique des versions</span></div>
</button>

After correction - remove the attribute aria-labelon the <button>element:

<button role="menuitem" class="sc-34780e96-0 jAUuhJ --docs--box-button ">
<div class="sc-34780e96-0 jwbyrB">
<span class="sc-34780e96-0 sc-262648e5-0 iiwUsF gukRvY --docs--icon-bg material-icons" aria-hidden="true">history</span>
<span class="sc-34780e96-0 sc-262648e5-0 iiwUsF dxYzTI">Historique des versions</span></div>
</button>

Describe alternatives you've considered
It's not a big deal but it simplifies the code reading especially if it's correct and accessible.

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions