Open
Conversation
WIP - updated swagger WIP - build passing AnalyzeHealthOperation wrapper working added analyze operation wrapper added tests for analyze and analyzehealth fix
suhas92
pushed a commit
that referenced
this pull request
Jan 14, 2021
* Updated version number * Try #2 on beta.1 * Fixed typo in version number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 3.2-preview.2 endpoint SDK.
Things to look out for -
Swagger file - (swagger-latest.json) I have made few edits on the swagger to make sure it is autogenerating code for wrapper implementation
Auto - Generated Code - All the files under /Generated folder are coming from swagger file, if you think we should have a change in generated ones, please comment on the swagger-latest.json for more clarity.
For each customization, I have added a new class with the same name which will add the customization.
AnalyzeHealthOperation.cs - This is the class for implementing the LRO pattern as described by the Azure .NET SDK guidelines.
AnalyzeHealthResultCollection.cs - Added this class as a wrapper for ReadOnlyCOllection on top of HealthcareResult.cs
Some customizations are around making Models internal to the SDK and are not exposed to the customer.
Some customizations are for renaming classes as many were not showing a correct naming pattern.