forked from smithy-lang/smithy
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Run the taggable resource validator only on resources bound to the se…
…rvice
- Loading branch information
Showing
5 changed files
with
180 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
...re/amazon/smithy/aws/traits/errorfiles/tagging/valid-tag-service-wide-two-services.errors
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| [WARNING] example.weather#Forecast: Resource is likely missing `aws.api#taggable` trait. | TaggableResource |
168 changes: 168 additions & 0 deletions
168
...re/amazon/smithy/aws/traits/errorfiles/tagging/valid-tag-service-wide-two-services.smithy
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,168 @@ | ||
| $version: "2.0" | ||
|
|
||
| metadata suppressions = [ | ||
| { | ||
| id: "UnstableTrait", | ||
| namespace: "example.weather" | ||
| } | ||
| ] | ||
|
|
||
| namespace example.weather | ||
|
|
||
| use aws.api#arn | ||
| use aws.api#taggable | ||
| use aws.api#tagEnabled | ||
|
|
||
| @tagEnabled | ||
| service Weather { | ||
| version: "2006-03-01", | ||
| resources: [City] | ||
| operations: [GetCurrentTime, TagResource, UntagResource, ListTagsForResource] | ||
| } | ||
|
|
||
| @internal | ||
| service AnotherService { | ||
| version: "2006-03-01" | ||
| resources: [AnotherResouce] | ||
| } | ||
|
|
||
| @arn(template: "resource/{resourceId}/another") | ||
| resource AnotherResouce { | ||
| identifiers: { | ||
| cityId: CityId | ||
| } | ||
| resources: [ | ||
| City | ||
| ] | ||
| } | ||
|
|
||
| structure Tag { | ||
| key: String | ||
| value: String | ||
| } | ||
|
|
||
| list TagList { | ||
| member: Tag | ||
| } | ||
|
|
||
| list TagKeys { | ||
| member: String | ||
| } | ||
|
|
||
| operation TagResource { | ||
| input := { | ||
| @required | ||
| arn: String | ||
| @length(max: 128) | ||
| tags: TagList | ||
| } | ||
| output := { } | ||
| } | ||
|
|
||
| operation UntagResource { | ||
| input := { | ||
| @required | ||
| arn: String | ||
| @required | ||
| tagKeys: TagKeys | ||
| } | ||
| output := { } | ||
| } | ||
|
|
||
| operation ListTagsForResource { | ||
| input := { | ||
| @required | ||
| arn: String | ||
| } | ||
| output := { | ||
| @length(max: 128) | ||
| tags: TagList | ||
| } | ||
| } | ||
|
|
||
| @arn( | ||
| template: "city/{cityId}/forecast/{forecastId}" | ||
| ) | ||
| resource Forecast { | ||
| identifiers: { | ||
| cityId: CityId | ||
| forecastId: ForecastId | ||
| } | ||
| } | ||
|
|
||
| @taggable(property: "tags") | ||
| @arn(template: "city/{CityId}") | ||
| resource City { | ||
| identifiers: { cityId: CityId } | ||
| properties: { | ||
| name: String | ||
| coordinates: CityCoordinates | ||
| } | ||
| read: GetCity | ||
| resources: [Forecast] | ||
| } | ||
|
|
||
| @pattern("^[A-Za-z0-9 ]+$") | ||
| string ForecastId | ||
|
|
||
| @pattern("^[A-Za-z0-9 ]+$") | ||
| string CityId | ||
|
|
||
| @readonly | ||
| operation GetCity { | ||
| input: GetCityInput | ||
| output: GetCityOutput | ||
| errors: [NoSuchResource] | ||
| } | ||
|
|
||
| @input | ||
| structure GetCityInput { | ||
| // "cityId" provides the identifier for the resource and | ||
| // has to be marked as required. | ||
| @required | ||
| cityId: CityId | ||
| } | ||
|
|
||
| @output | ||
| structure GetCityOutput { | ||
| // "required" is used on output to indicate if the service | ||
| // will always provide a value for the member. | ||
| @required | ||
| name: String, | ||
|
|
||
| @required | ||
| coordinates: CityCoordinates | ||
| } | ||
|
|
||
| // This structure is nested within GetCityOutput. | ||
| structure CityCoordinates { | ||
| @required | ||
| latitude: Float, | ||
|
|
||
| @required | ||
| longitude: Float, | ||
| } | ||
|
|
||
| // "error" is a trait that is used to specialize | ||
| // a structure as an error. | ||
| @error("client") | ||
| structure NoSuchResource { | ||
| @required | ||
| resourceType: String | ||
| } | ||
|
|
||
| @readonly | ||
| operation GetCurrentTime { | ||
| input: GetCurrentTimeInput | ||
| output: GetCurrentTimeOutput | ||
| } | ||
|
|
||
| @input | ||
| structure GetCurrentTimeInput {} | ||
|
|
||
| @output | ||
| structure GetCurrentTimeOutput { | ||
| @required | ||
| time: Timestamp | ||
| } | ||
|
|