-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP8 fixes #919
base: master
Are you sure you want to change the base?
PEP8 fixes #919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good.
sugar/src/jarabe/model/friends.py Line 82 in 5b0e880
The above line or any such line shows a warning "Unexpected argument". I couldn't be able to get why it so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
65ef89c
to
955c19f
Compare
7963995
to
d63da3d
Compare
sugar/src/jarabe/desktop/favoritesview.py Line 201 in d59b62a
The way we have defined _set_layout is not correct way. Setter should not return any value. |
64cc0e1
to
0e342bf
Compare
@quozl @pro-panda Please review. |
@Saumya-Mishra9129 although, not a big issue, there is a typo on dbddda3 's commit message |
@quozl Can you please tell me why we used Webkit and Webkit2 support for Sugar.? I am a little confused about it. |
@Saumya-Mishra9129, sure, you can see in the commit descriptions of the commits that changed the imports. Some systems on which Sugar is being used did not have WebKit2, so both versions are supported by Sugar. |
1013ec8
to
2085c57
Compare
Thanks |
No description provided.