-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Tamagtochi Widget #852
base: master
Are you sure you want to change the base?
Conversation
Add Tamagotchi widget code. The XO icon responds/changes according to changes in number of journal entries, battery status, and disk status. Please use https://github.com/Hrishi1999/sugar-artwork/tree/tamagotchi-widget to test this feature.
I hate to be "that guy" but the word Tamagotchi is trademarked, and actively in force. It would be in our best interest to not use it in this, or any other, context. See https://trademarks.justia.com/752/47/tamagotchi-75247559.html Please consider changing the name to a more generic term prior to release. |
Thanks, we discussed this topic in the GSoC Weekly meeting (http://meeting.sugarlabs.org/sugar-meeting/2019-08-12). I will change it. |
@quozl Review? |
I've lost track of your plan. I can't find a feature page on the Wiki.
You're asking for a merge to master branch, so that means you are targeting future release of Sugar, not OLPC XO laptops. But you were careful to get the Dashboard tested on Fedora 18. I'm confused as to what you want to do. Tell me more?
|
This feature is not a dashboard. This is a widget, which replaces the XO icon on the Sugar desktop. I've also opened a pull request for Dashboard integration. My GSoC project includes two projects 1) This widget (to be renamed) 2) Dashboard. |
Thanks. You are intending Tamagtochi for master. Please fill out the feature template. If you don't have a Wiki account, then either get one or add the answers to the pull request. I've briefly reviewed the change;
|
I will try to fix these issues this week. Thanks. |
Added `variable-buddy-icon` to schema `org.sugarlabs`. It's set to false by default. Enabling it will enabled the variable appearance of buddyicon.
@quozl Added gsettings key in 740eea4 |
That's expected. Modularity has several advantages in software development. If a module has a clear purpose (interface to battery), and callers don't need 100% of the functionality, it's normal.
Yes, I expect so. You can create signals if you need them. |
'battery-present' and 'battery-level' keys will be used to set the value from extensions.deviceicon.battery. Those values will be now used in buddyicon, that removes duplicate code from buddyicon.
Instead of calling a datastore query every 60 seconds, instead connect 'Updated' and 'Deleted' signals and maintain a count,
@quozl I tried to connect with |
Yes, that's right. As you can see from the datastore source, updated signal occurs when a journal object is changed by an activity or Sugar, and that won't change the number of objects unless the find is given search criteria. Is there a feature page yet? |
@@ -109,7 +117,7 @@ def __get_battery(self): | |||
def __status_tooltip(self, has_battery=False): | |||
disk_usage = (self.used * 100) / self.total | |||
battery = '' | |||
if has_battery: | |||
if self.has_battery: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your change here to use self.has_battery
means the keyword argument is not needed?
I will create a feature page this week. The |
Thanks. |
It's been almost a month and there hasn't been;
I don't think anyone else has seen it. Do what you can to get input? |
@Hrishi1999 I have created a small update on your repo. I am not getting any visible changes to the XO icon on the Home page, I have built sugar-artwork from |
Adds Tamagotchi widget. The XO icon responds/changes according to changes in the number of journal entries, battery status, and disk status.
Please use https://github.com/Hrishi1999/sugar-artwork/tree/tamagotchi-widget to test this feature since the artwork for Tamagotchi widget is not complete.