Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port math related methods to MathUtility #2357

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

meganindya
Copy link
Member

I've moved the math related methods from Logo to MathUtility in a new file utils/mathutils.js. I've actually created the class MathUtility, and all methods are static.

I've refactored the arg methods corresponding to the 10 methods that I moved, in a way that arg methods handle only activity specific to blocks, while the static methods verify the input and produce results accordingly. I've used exception handling to communicate between the two disconnected operations.

@walterbender
Copy link
Member

Looks good but could you rebase so that your previous commit is not also folded in to this PR? Thx

@meganindya meganindya marked this pull request as ready for review June 17, 2020 19:01
@meganindya
Copy link
Member Author

Yeah, I just did that. logo-refactor-1 is 2 commits ahead now. But, it doesn't show here.

@meganindya
Copy link
Member Author

A soft-reset followed by a force push fixed this :p

@walterbender walterbender merged commit 8a88aef into sugarlabs:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants