Skip to content

Port Turtle component to MVC #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 5, 2020
Merged

Port Turtle component to MVC #2312

merged 6 commits into from
Jun 5, 2020

Conversation

meganindya
Copy link
Member

@meganindya meganindya commented Jun 4, 2020 •
edited
Loading

  • Update the MVC framework: 1b37236, 9171f63
  • Create and load TurtleModel and TurtleView
  • Move model specific methods to TurtleModel
  • Move view specific methods to TurtleView

@meganindya meganindya changed the title Turtle component Port Turtle component to MVC Jun 4, 2020
vaibhavdaren
vaibhavdaren reviewed Jun 4, 2020
View reviewed changes
@meganindya meganindya marked this pull request as ready for review June 5, 2020 07:07
@meganindya
Copy link
Member Author

meganindya commented Jun 5, 2020 •
edited
Loading

@walterbender this is ready for now. Some renaming I plan to do after #2313 is cleared, since there's some overlap.

@meganindya meganindya mentioned this pull request Jun 5, 2020
Merged
5 tasks
@walterbender walterbender merged commit 14e18e4 into sugarlabs:master Jun 5, 2020
@meganindya meganindya deleted the turtle-component branch June 5, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaibhavdaren vaibhavdaren vaibhavdaren left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meganindya @vaibhavdaren @walterbender