-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turtles MVC component #2309
Turtles MVC component #2309
Conversation
This is mostly done except for the |
One test I did on your branch was to export lilypond. I started from Walter's Rainbow Connection in Examples folder. It returned this error, visible in console:
|
@pikurasa I looked into the code and faced another "there you are" moment. I'm sure there'll be more of these, now that I've ported the old syntax to ES6 classes: weird ways how old JavaScript works. Thanks for spotting this. Hopefully, the application's general behaviour will be more stable once I start working on @walterbender Since this is a minor one I'm pushing the commit in this PR. Yet another variable declaration bug. |
Also, sometime later we should improve the complexity of some of the algorithms inside. This example crashes my browser every time. :P |
It is a long project. It loads, but after about 30-60 seconds. It would be nice, at the very least, if the user knew how much longer to wait until the project is fully loaded. |
Setup
Turtles
class in a separate file and load it inactivity.js
TurtlesModel
andTurtlesView
classes formodel
andview
respectivelyTurtlesModel
andTurtlesView
intoTurtles
(controller
)TurtlesModel
andTurtlesView
after instantiating them, and delete the separatemodel
andview
objects to free redundant memorySeparation
model
specific members toTurtlesModel
view
specific members toTurtlesView
getters
to access membersTurtles
component
members withgetters
private
members