Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/log cleanup #248

Merged
merged 21 commits into from
Jan 28, 2025
Merged

Refactor/log cleanup #248

merged 21 commits into from
Jan 28, 2025

Conversation

D4nDude
Copy link

@D4nDude D4nDude commented Dec 13, 2024

Changes

  • Created a global log reference to reduce references to log thread throughout code.
  • Changed Macro to not accept log_ptr.
  • Updated all known Logging messages to new format
  • Fixed warnings from log macros
  • Add a timestamp to all log messages

Fixed Issue(s)

Closes #N/A

Checklist

  • Code has been tested on STM32 hardware.
  • Changes do not generate any new compiler warnings.
  • Code has been formatted using trunk fmt.
  • Commit messages follow the Conventional Commits specification.

Additional Notes

BREAKING CHANGE: Reworked Macro API for Making Log messages

Branch Rebased onto dyno before creating pull request.

@D4nDude D4nDude self-assigned this Dec 13, 2024
@Avdieienko
Copy link
Member

So far looks good. I will test it on the VCU sometime next week.

@D4nDude D4nDude added the refactor Rewriting/restructuring code without changing behaviour label Dec 20, 2024
@Avdieienko
Copy link
Member

@D4nDude Tested it on VCU. Not sure about the need for timestamps, as they are associated with every log call (even within the same timestamp) and might make the logs a bit messy.

@Avdieienko Avdieienko merged commit 47515e2 into dyno Jan 28, 2025
@Avdieienko Avdieienko deleted the refactor/log-cleanup branch January 28, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Rewriting/restructuring code without changing behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants