Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add support for tls connections in network-v2 rpc client #1655

Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix: add support for tls connections in network-v2 rpc client #1655

merged 2 commits into from
Oct 17, 2024

Conversation

yourbuddyconner
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

SP1 Performance Test Results

Branch: conner/network-sdk-tls
Commit: fc8f2ade
Author: yourbuddyconner

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.18 2.73 0.45 25s ✅
ssz-withdrawals 2757356 9.60 119.87 38.59 1m12s ✅
tendermint 12593597 5.02 236.73 106.41 2m1s ✅

mattstam
mattstam reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@mattstam mattstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome find! just some super small nits

@yourbuddyconner yourbuddyconner marked this pull request as ready for review October 17, 2024 18:18
@mattstam mattstam merged commit 1b0d5fe into dev Oct 17, 2024
8 checks passed
@mattstam mattstam deleted the conner/network-sdk-tls branch October 17, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattstam mattstam mattstam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yourbuddyconner @mattstam