fix(sp1-build, workflows): docker tag #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattstam
approved these changes
Oct 11, 2024
|
SP1 Performance Test Results Branch: ratan/fix-docker-tag
|
ratankaliani
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The correct tag for pulling the Docker container that
sp1-buildshould use islatest.latestshould be created on every push tomain.While making this PR, I noticed that we don't trigger the
docker-publish.ymlanddocker-publish-gnark.ymlon pushes to main. This meant in the past that we manually set thelatesttag. Now, we trigger the workflow on a push tomain, which will auto-generate thelatesttag.