feat: new include_elf! macro for importing ELF
#1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SP1 Performance Test Results Branch: jon/gro-155-use-elf-from-target-instead-of-copying
|
puma314
reviewed
Oct 8, 2024
|
Sure I can make all existing examples use this new syntax. |
puma314
reviewed
Oct 8, 2024
| .find(|p| &p.id == program_crate) | ||
| .ok_or_else(|| anyhow::anyhow!("cannot find package for {}", program_crate))?; | ||
|
|
||
| for bin_target in program.targets.iter().filter(|t| { |
There was a problem hiding this comment.
So we ignore --bin targets?
There was a problem hiding this comment.
Nope. Exactly the opposite. We only care about bin targets.
In terms of the --bin flag, this is currently arlready supported as an option before this PR. When that flag is used it only builds one target specified by it. So what's done here is just to preserve that behavior.
xJonathanLEI
force-pushed
the
jon/gro-155-use-elf-from-target-instead-of-copying
branch
from
dc566a3
to
016b8d1
Compare
jtguibas
approved these changes
Oct 9, 2024
xJonathanLEI
deleted the
jon/gro-155-use-elf-from-target-instead-of-copying
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new mechanism of importing ELF files without breaking the existing ELF-copying behaviour. Note that this backward-compatibility is preserved only when building a single target, which is fine as building multiple binary targets doesn't even work at the moment in the first place.
A follow-up PR should add an option to turn off the ELF-copying behaviour.