feat: only call entrypoint in zkvm #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xJonathanLEI
force-pushed
the
jon/entrypoint_zkvm_only
branch
from
309599d
to
1c885c0
Compare
|
SP1 Performance Test Results Branch: jon/entrypoint_zkvm_only
|
puma314
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Why do we need all of these to be pub?
There was a problem hiding this comment.
Because otherwise they would be marked as unused when building against the host, so you get false positives running say cargo clippy. The template repo has it as pub too.
puma314
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guards call to the user-defined entrypoint by
#[cfg(target_os = "zkvm")].This is helpful to prevent errors when compiling against a non-zkVM target, which can often happen when a program is included in the root workspace and users clone and simply build everything in the workspace.
Ideally, users should exclude zkVM programs when building against the host target, as it's wasted work anyway. However, wasted work is still better than throwing a compilation error directly.