Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove individual test workspaces #1597

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Conversation

xJonathanLEI
Copy link
Contributor

Same as #1566 but for the tests folder. Makes these changes:

  • adds a root workspace at tests/Cargo.toml and removes all individual test workspaces;
  • fixes all compilation errors in tests resulting from being unmaintained;
  • adds a CI job for linting and building crates in tests.

Using a single worksapce dramatically reduces compilation time. On a Macbook Pro with M3 Max, running make in the tests folder on a fresh repo clone took 5m28.870s, but this PR brings it down to 0m43.894s, down by 86%.

Copy link

github-actions bot commented Oct 3, 2024

SP1 Performance Test Results

Branch: jon/tests_workspace
Commit: b32646d
Author: xJonathanLEI

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.18 5.92 0.16 1m12s
ssz-withdrawals 2757356 17.34 63.43 17.31 2m39s
tendermint 12593597 6.60 165.03 63.53 3m20s

@xJonathanLEI xJonathanLEI enabled auto-merge (squash) October 3, 2024 04:23
@xJonathanLEI xJonathanLEI merged commit 6861f69 into dev Oct 3, 2024
24 checks passed
@xJonathanLEI xJonathanLEI deleted the jon/tests_workspace branch October 3, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants