Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove non-existent feature #1590

Merged
merged 1 commit into from
Oct 3, 2024
Merged

chore: remove non-existent feature #1590

merged 1 commit into from
Oct 3, 2024

Conversation

xJonathanLEI
Copy link
Contributor

The interface feature has been removed way back in e128143, but sp1-zkvm still uses it for a cfg section.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

SP1 Performance Test Results

Branch: jon/no_interface_feature
Commit: 97060b81
Author: xJonathanLEI

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.18 5.79 0.16 1m11s ✅
ssz-withdrawals 2757356 17.06 63.48 17.46 2m38s ✅
tendermint 12593597 6.51 166.29 64.06 3m19s ✅

@xJonathanLEI xJonathanLEI enabled auto-merge (squash) October 2, 2024 19:34
@xJonathanLEI xJonathanLEI merged commit c1eabe3 into dev Oct 3, 2024
23 checks passed
@xJonathanLEI xJonathanLEI deleted the jon/no_interface_feature branch October 3, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctian1 ctian1 ctian1 approved these changes

@jtguibas jtguibas Awaiting requested review from jtguibas

@puma314 puma314 Awaiting requested review from puma314

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xJonathanLEI @ctian1