fix: gnark-ffi Dockerfile caching #1564
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current cache mount in
Dockerfile.gnark-ffi
is broken:/sp1/crates/recursion/gnark-cli/target
instead of/sp1/target
, which is useless and as a result doesn't really cache anything. Any Docker build context changes would trigger a full rebuild./usr/local/cargo/registry
, which is the directory the build image uses for Cargo cache.