Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gnark-ffi Dockerfile caching #1564

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: gnark-ffi Dockerfile caching #1564

merged 1 commit into from
Sep 30, 2024

Conversation

xJonathanLEI
Copy link
Contributor

The current cache mount in Dockerfile.gnark-ffi is broken:

  1. It's mounting a cache dir at /sp1/crates/recursion/gnark-cli/target instead of /sp1/target, which is useless and as a result doesn't really cache anything. Any Docker build context changes would trigger a full rebuild.
  2. It's not caching the Cargo registry. Even after fixing the issue above, any context change would still trigger a full dependency crate download. The correct solution is to also cache /usr/local/cargo/registry, which is the directory the build image uses for Cargo cache.

@xJonathanLEI xJonathanLEI merged commit 11b75da into dev Sep 30, 2024
1 check passed
@xJonathanLEI xJonathanLEI deleted the jon/dockerfile branch September 30, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants