Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace raw() with bytes() in fibonacci example #1549

Merged
merged 1 commit into from
Sep 26, 2024
Merged

chore: replace raw() with bytes() in fibonacci example #1549

merged 1 commit into from
Sep 26, 2024

Conversation

xJonathanLEI
Copy link
Contributor

Using methods that return vectors or slices is more idiomatic.

@xJonathanLEI xJonathanLEI enabled auto-merge (squash) September 26, 2024 19:55
@mattstam
Copy link
Contributor

matches up with https://github.com/succinctlabs/sp1-project-template/blob/main/script/src/bin/evm.rs#L99 so lgtm

@github-actions GitHub Actions
Copy link

SP1 Performance Test Results

Branch: jon/replace_raw_with_bytes
Commit: 5a93793e
Author: xJonathanLEI

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.18 5.54 0.15 1m14s ✅
ssz-withdrawals 2757356 17.12 63.77 17.09 2m42s ✅
tendermint 12593597 6.34 164.82 63.16 3m21s ✅

@xJonathanLEI xJonathanLEI merged commit c9b305b into dev Sep 26, 2024
23 checks passed
@xJonathanLEI xJonathanLEI deleted the jon/replace_raw_with_bytes branch September 26, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattstam mattstam mattstam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xJonathanLEI @mattstam