-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LookupId struct instead of u128 #1427
Conversation
@tamirhemo - fyi |
@@ -27,15 +27,16 @@ pub struct AluEvent { | |||
/// The third operand. | |||
pub c: u32, | |||
/// The result of the operation. | |||
pub sub_lookups: [u128; 6], | |||
/// make in the format of [``LookupId``; 6] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments should be full sentence with proper punctuation, this is unprofessional
} | ||
|
||
//use crate::events::create_alu_lookup_id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not leave random commented lines around
@@ -1,14 +1,14 @@ | |||
use serde::{Deserialize, Serialize}; | |||
|
|||
use crate::events::memory::{MemoryReadRecord, MemoryWriteRecord}; | |||
|
|||
use crate::events::LookupId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a space after an import
SP1 Performance Test Results PR: feat: LookupId struct instead of u128
|
I changed usages of lookup ids as u128 into structs of 4 u32s, this is done to be compatible with c data types.