feat: LookupId struct instead of u128 #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 28, 2024 16:46
|
@tamirhemo - fyi |
added 2 commits
August 28, 2024 17:31
jtguibas
reviewed
Aug 29, 2024
jtguibas
reviewed
Aug 29, 2024
| @@ -27,15 +27,16 @@ pub struct AluEvent { | |||
| /// The third operand. | |||
| pub c: u32, | |||
| /// The result of the operation. | |||
| pub sub_lookups: [u128; 6], | |||
| /// make in the format of [``LookupId``; 6] | |||
There was a problem hiding this comment.
comments should be full sentence with proper punctuation, this is unprofessional
jtguibas
reviewed
Aug 29, 2024
| } | ||
|
|
||
| //use crate::events::create_alu_lookup_id; |
There was a problem hiding this comment.
please do not leave random commented lines around
jtguibas
reviewed
Aug 29, 2024
| @@ -1,14 +1,14 @@ | |||
| use serde::{Deserialize, Serialize}; | |||
|
|
|||
| use crate::events::memory::{MemoryReadRecord, MemoryWriteRecord}; | |||
|
|
|||
| use crate::events::LookupId; | |||
There was a problem hiding this comment.
please add a space after an import
jtguibas
approved these changes
Aug 29, 2024
|
SP1 Performance Test Results PR: feat: LookupId struct instead of u128
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed usages of lookup ids as u128 into structs of 4 u32s, this is done to be compatible with c data types.