Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Overview
Previously, Docker builds were failing for 2 issues.
Because setting
CARGO_TARGET_DIR
in the local environment did not carry into Docker, the build location of the program did not match the expected build directory incopy_elf_to_output_dir
.The program directory was not canonicalized in
create_docker_command
, resulting inStripPrefixError
if the specified program path inbuild_program_with_args
was a relative path and Docker mode was on.Ex.
Resolution
CARGO_TARGET_DIR
explicitly with-e
in the Docker command.