feat: add missing rels to rel message#582
Conversation
…tances of 'tuple' with 'record'.
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
|
This is failing the breaking change check for these two reasons: Since these were technically unreachable features (from |
I'd be inclined to just say that it will break to compilation for anyone using them directly. |
Fair enough. |
EpsilonPrime
left a comment
There was a problem hiding this comment.
A good step forward, thanks!
The
ReferenceRel,WriteRel, andDdlRelwere defined inalgebra.protobut not partof
message Relwhich meant they were unusable. This PR adds those back. It isinspired by #288 but more targeted in scope. One change from that original PR which I
also kept was replacing the word
tuplewithrecordin the documentation for consistency.This is not to imply that
ReferenceRel,WriteRel, orDdlRelare "complete" or "stable"in any way. I feel these relations are still quite ill defined. However, my hope is that by
making them usable we can inspire further change to them.
BREAKING CHANGE: The enum
WriteRel::OutputModehad an option change fromOUTPUT_MODE_MODIFIED_TUPLEStoOUTPUT_MODE_MODIFIED_RECORDSBREAKING CHANGE: The message
AggregateFunction.ReferenceRelhas movedto
ReferenceRel.