fix: add overflow behavior to integer division#223
Merged
jacques-n merged 1 commit intosubstrait-io:mainfrom Jul 12, 2022
Merged
fix: add overflow behavior to integer division#223jacques-n merged 1 commit intosubstrait-io:mainfrom
jacques-n merged 1 commit intosubstrait-io:mainfrom
Conversation
Member
Author
|
CC @sanjibansg who discovered this discrepency |
Contributor
|
Good catch. Do we need to add to decimal as well? As a note, I don't see the the introduction of an optional argument to a function as a breaking change so consider this fix identification as a valid non-breaking change. (I think you went through this as well but want to call out explicitly.) |
Contributor
|
Ping here on Decimal. |
jacques-n
requested changes
Jul 4, 2022
Contributor
jacques-n
left a comment
jacques-n
left a comment
There was a problem hiding this comment.
Looking for same changes wrt to Decimal.
Member
Author
|
@jacques-n I'm not sure I understand. Division for decimal already specifies overflow I think: |
jacques-n
approved these changes
Jul 12, 2022
Contributor
jacques-n
left a comment
jacques-n
left a comment
There was a problem hiding this comment.
Thanks for being patient!
curino
pushed a commit
to curino/substrait
that referenced
this pull request
Jul 20, 2022
BREAKING CHANGE: The signature of divide functions for multiple types now specify an enumeration prior to specifying operands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on apache/arrow#13285 we noticed that there is no overflow behavior for division. My first thought was that overflow is not possible on division but it turns out that there is one special case of overflow when the data type is signed integers.
For example, consider 8 bit signed integers. The range is -128,127. However,
-128 / -1 => 128which is outside the range. I'm not entirely sure whatSATURATEwould mean in this case but it seems it could mean 127 for the simplicity of having one set of overflow handling options for all the arithmetic.