fix(naming): add missing arg names in functions_logarithmic.yaml and …

…functions_set.yaml (#319)
substrait-io · Sep 8, 2022 · 1c14d27 · 1c14d27
1 parent b7347d1
commit 1c14d27
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/extensions/functions_logarithmic.yaml b/extensions/functions_logarithmic.yaml
@@ -12,7 +12,8 @@ scalar_functions:
           - name: on_domain_error
             options: [ NAN, ERROR ]
             required: false
-          - value: fp32
+          - name: x
+            value: fp32
         return: fp32
       - args:
           - name: rounding
@@ -21,7 +22,8 @@ scalar_functions:
           - name: on_domain_error
             options: [ NAN, ERROR ]
             required: false
-          - value: fp64
+          - name: x
+            value: fp64
         return: fp64
   -
     name: "log10"
@@ -34,7 +36,8 @@ scalar_functions:
           - name: on_domain_error
             options: [ NAN, ERROR ]
             required: false
-          - value: fp32
+          - name: x
+            value: fp32
         return: fp32
       - args:
           - name: rounding
@@ -43,7 +46,8 @@ scalar_functions:
           - name: on_domain_error
             options: [ NAN, ERROR ]
             required: false
-          - value: fp64
+          - name: x
+            value: fp64
         return: fp64
   -
     name: "log2"
@@ -56,7 +60,8 @@ scalar_functions:
           - name: on_domain_error
             options: [ NAN, ERROR ]
             required: false
-          - value: fp32
+          - name: x
+            value: fp32
         return: fp32
       - args:
           - name: rounding
@@ -65,7 +70,8 @@ scalar_functions:
           - name: on_domain_error
             options: [ NAN, ERROR ]
             required: false
-          - value: fp64
+          - name: x
+            value: fp64
         return: fp64
   -
     name: "logb"

diff --git a/extensions/functions_set.yaml b/extensions/functions_set.yaml
@@ -18,7 +18,9 @@ scalar_functions:
       - args:
           - options: [ NAN_IS_NAN, NAN_IS_NOT_NAN ]
             required: false
-          - value: T
-          - value: List<T>
+          - name: x
+            value: T
+          - name: y
+            value: List<T>
         nullability: DECLARED_OUTPUT
         return: int64?