fix: replace yaml-rust with serde_yaml to fix parsing of NAN#40
Merged
jvanstraten merged 1 commit intosubstrait-io:mainfrom Aug 16, 2022
Merged
Conversation
jvanstraten
force-pushed
the
yaml-rs-to-serde-yaml
branch
from
d14b9cb to
f4f3e6f
Compare
yaml-rust incorrectly treats NAN as a keyword for NaN floats, and the library seems more-or-less abandoned. IIRC serde_yaml used to wrap around it, but it now has its own parser (based around libyaml, it seems), and handles this correctly.
jvanstraten
force-pushed
the
yaml-rs-to-serde-yaml
branch
from
f4f3e6f to
4e012d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yaml-rust incorrectly treats NAN as a keyword for NaN floats, and
the library seems more-or-less abandoned. IIRC serde_yaml used to
wrap around it, but it now has its own parser (based around libyaml,
it seems), and handles this correctly.