feat: introduce meta-type system for type parameters and derivations#32
Merged
jvanstraten merged 6 commits intosubstrait-io:mainfrom Aug 18, 2022
Merged
Conversation
jvanstraten
force-pushed
the
meta-type-system
branch
3 times, most recently
from
6457528 to
fbb2477
Compare
BREAKING CHANGE: many Rust types were changed or changed location. There is also a minor change in the validator output protos relating to the representation of the system-preferred variation.
jvanstraten
force-pushed
the
meta-type-system
branch
from
fbb2477 to
99a710f
Compare
…ormity BREAKING CHANGE: named type parameters are now represented differently in the proto output of the validator, to more closely match the new internal structure
jvanstraten
force-pushed
the
meta-type-system
branch
from
4fde168 to
c1df700
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal for this PR is to refactor everything to do with type parameters to a complete type system that will also be useful for type derivations, ideally with consistent naming. This will be a breaking change for the Rust API.