Merged
Conversation
45dfded to
c3fa31d
Compare
d9252ad to
d23b075
Compare
Contributor
Author
|
Ah! I just found a comment explaining why the
Well, I'm doing it here! I'll add a commit updating that comment. |
mbrobbel
reviewed
Nov 4, 2024
manywheels is needed for building wheels for many linux versions, so we need it; put it back. But include protoc in the container to fix the build
mbrobbel
approved these changes
Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
prost{-*},pyo3, andcbindgendependencies.pyo3in particular was causing a build error in other PRs. This PR should now pass all CI.Notes
In addition to updating the dependency versions and the code that calls it where necessary, I also found that
protocwas missing in a number of CI jobs where it seemed to be needed. I'm not sure how this worked before; my best guess was that the generated code was cached and carried over, and updatingprostchanged that.Build Error
in particular, this is intended to fix this error: