Bump prost-build to 0.10 to solve protobuf version incompatibility#2
Merged
jacques-n merged 1 commit intosubstrait-io:mainfrom May 30, 2022
Merged
Conversation
This was referenced May 30, 2022
Should help solve the issue described in [1] by effectively upgrading protoc from 3.15.8 to 3.19.4. However, from now on either protoc needs to already be installed on the system to install, or prost-build needs to have the tools available to build it from source (needs CMake an C++ toolchain). [1] protocolbuffers/protobuf#10051
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should help solve the issue described here and here by effectively upgrading protoc from 3.15.8 to 3.19.4. However, from now on either protoc needs to already be installed on the system to install, or prost-build needs to have the tools available to build it from source (needs CMake an C++ toolchain).
ETA: Rerunning CI on my fork shows that this has actually broken again for no apparent reason, turning into draft.forgot to increment one of instances of the dependency, no idea how it ever passed before this 🤷