feat: relations, schemas, and sources in the text format #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonpace
changed the title
westonpace
requested changes
Mar 8, 2023
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
Some initial thoughts (I don't think anything major).
src/substrait/textplan/converter/tests/BinaryToTextPlanConversionTest.cpp
Outdated
Show resolved
Hide resolved
src/substrait/textplan/converter/tests/BinaryToTextPlanConversionTest.cpp
Outdated
Show resolved
Hide resolved
westonpace
approved these changes
Mar 13, 2023
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
Some minor nits and then we can merge
src/substrait/textplan/converter/tests/BinaryToTextPlanConversionTest.cpp
Outdated
Show resolved
Hide resolved
* Adds support for relations, schemas, and sources. * Does not add support for pipelines and expressions. * Changes locations for binary to text conversion to use protobuffer message pointers. * Moves proto enum to string functionality into the proto module. The next PR will add expressions, fields, and literals.
…ts matchers such as Eq and StrContains. Also added EqSuashingWhitespace to compare strings ignoring differences in whitespace.
EpsilonPrime
force-pushed
the
converter-part2
branch
from
188522a to
4e4758e
Compare
EpsilonPrime
added a commit
to EpsilonPrime/substrait-cpp
that referenced
this pull request
May 6, 2023
…o#32) * Adds support for relations, schemas, and sources. * Does not add support for pipelines and expressions. * Changes locations for binary to text conversion to use protobuffer message pointers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next PR will add expressions, fields, and literals.