Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add approve type and timestamp in approve record #187

Merged
merged 1 commit into from
May 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion public/locales/en/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,9 @@
"cancelled": "Cancelled",
"executed": "Executed",
"index": "Status",
"pending": "Pending"
"pending": "Pending",
"initialized": "Intialized",
"approvedAndExecuted": "Approved And Executed"
},
"save": "Save",
"add": "Add",
Expand Down
4 changes: 3 additions & 1 deletion public/locales/zh/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,9 @@
"cancelled": "已取消",
"executed": "已执行",
"index": "状态",
"pending": "等待批准"
"pending": "等待批准",
"initialized": "已发起",
"approvedAndExecuted": "批准并执行"
},
"save": "保存",
"add": "添加",
Expand Down
60 changes: 46 additions & 14 deletions src/components/Entries.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { Trans, useTranslation } from 'react-i18next';
import { APPROVE_RECORD_QUERY } from '../config';
import { useApi, useIsInjected } from '../hooks';
import { AddressPair, Entry, Network, TxActionType } from '../model';
import { toShortString } from '../utils';
import { toShortString, formatDate } from '../utils';
import { ArgObj, Args } from './Args';
import { genExpandIcon } from './expandIcon';
import { MemberList } from './Members';
Expand All @@ -26,6 +26,8 @@ interface ApproveRecord {
multisigRecordId: string;
account: string;
approveTimepoint: string;
approveTimestamp: string;
approveType: string;
}

export interface EntriesProps {
Expand Down Expand Up @@ -88,31 +90,61 @@ function MemberStatus(props: { entry: Entry; pair: KeyringJson; isInProgress: bo
height: matchedApproveRecord.approveTimepoint.split('-')[0],
index: matchedApproveRecord.approveTimepoint.split('-')[1],
};

const approveTypeTrans =
matchedApproveRecord.approveType === 'initialize'
? 'status.initialized'
: matchedApproveRecord.approveType === 'execute'
? 'status.approvedAndExecuted'
: 'status.approved';

return (
<>
<div className="flex items-center">
<Trans>{approveTypeTrans}</Trans> (
<SubscanLink extrinsic={approveTimepoint}>{matchedApproveRecord.approveTimepoint}</SubscanLink>)
</div>
<div className="text-xs scale-90 origin-left">{formatDate(matchedApproveRecord.approveTimestamp)}</div>
</>
);
}

if (!approved) {
return <div>-</div>;
}

const matched = inProgressApproveRecords?.approveRecords.nodes.find((item) => item.account === address);

if (!matched) {
return (
<div className="flex items-center">
<Trans>status.approved</Trans> (
<SubscanLink extrinsic={approveTimepoint}>{matchedApproveRecord.approveTimepoint}</SubscanLink>)
<Trans>status.approved</Trans>
</div>
);
}

const matched = inProgressApproveRecords?.approveRecords.nodes.find((item) => item.account === address);
const inProgressApproveTimepoint = {
height: matched?.approveTimepoint.split('-')[0] || '',
index: matched?.approveTimepoint.split('-')[1] || '',
height: matched.approveTimepoint.split('-')[0] || '',
index: matched.approveTimepoint.split('-')[1] || '',
};

return approved ? (
<div className="flex items-center">
<Trans>status.approved</Trans>
{matched && (
const approveTypeTrans =
matched.approveType === 'initialize'
? 'status.initialized'
: matched.approveType === 'execute'
? 'status.approvedAndExecuted'
: 'status.approved';

return (
<>
<div className="flex items-center">
<Trans>{approveTypeTrans}</Trans>
<div>
(<SubscanLink extrinsic={inProgressApproveTimepoint}>{matched.approveTimepoint}</SubscanLink>)
</div>
)}
</div>
) : (
<div>-</div>
</div>
<div className="text-xs scale-90 origin-left">{formatDate(matched.approveTimestamp)}</div>
</>
);
}

Expand Down
2 changes: 2 additions & 0 deletions src/components/ExtrinsicRecords.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ interface MultisigRecord {
export interface ApproveRecord {
account: string;
approveTimepoint: string;
approveTimestamp: string;
approveType: string;
}

const { TabPane } = Tabs;
Expand Down
2 changes: 1 addition & 1 deletion src/config/chains/crab.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"displayName": "Crab",
"rpc": "wss://crab-rpc.darwinia.network",
"api": {
"subql": "https://api.subquery.network/sq/itering/multisig_crab"
"subql": "https://api.subquery.network/sq/itering/multisig_crab__aXRlc"
},
"logo": "/image/crab-button-mobile.png",
"explorerHostName": "crab",
Expand Down
2 changes: 1 addition & 1 deletion src/config/chains/darwinia.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"displayName": "Darwinia",
"rpc": "wss://rpc.darwinia.network",
"api": {
"subql": "https://api.subquery.network/sq/itering/multisig_darwinia"
"subql": "https://api.subquery.network/sq/itering/multisig_darwinia__aXRlc"
},
"logo": "/image/darwinia-button-mobile.png",
"explorerHostName": "darwinia",
Expand Down
2 changes: 1 addition & 1 deletion src/config/chains/kusama.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"displayName": "Kusama",
"rpc": "wss://kusama.api.onfinality.io/public-ws",
"api": {
"subql": "https://api.subquery.network/sq/itering/multisig_ksm"
"subql": "https://api.subquery.network/sq/itering/multisig_ksm__aXRlc"
},
"logo": "/image/kusama-button-mobile.png",
"explorerHostName": "kusama",
Expand Down
2 changes: 1 addition & 1 deletion src/config/chains/pangolin.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"isTestnet": true,
"rpc": "wss://pangolin-rpc.darwinia.network/",
"api": {
"subql": "https://api.subquery.network/sq/itering/multisig_pangolin"
"subql": "https://api.subquery.network/sq/itering/multisig_pangolin__aXRlc"
},
"logo": "/image/pangolin-button-mobile.png",
"explorerHostName": "pangolin",
Expand Down
2 changes: 1 addition & 1 deletion src/config/chains/polkadot.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"displayName": "Polkadot",
"rpc": "wss://rpc.polkadot.io",
"api": {
"subql": "https://api.subquery.network/sq/itering/multisig_polkadot"
"subql": "https://api.subquery.network/sq/itering/multisig_polkadot__aXRlc"
},
"logo": "/image/polkadot-button-mobile.png",
"explorerHostName": "polkadot",
Expand Down
4 changes: 4 additions & 0 deletions src/config/query.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ export const MULTISIG_RECORD_QUERY = `
nodes {
account
approveTimepoint
approveTimestamp
approveType
}
}

Expand Down Expand Up @@ -73,6 +75,8 @@ query approveRecords($multisigRecordId: String!) {
multisigRecordId
account
approveTimepoint
approveTimestamp
approveType
}
}
}
Expand Down
1 change: 1 addition & 0 deletions src/utils/helper/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ export * from './multisig';
export * from './types';
export * from './url';
export * from './validate';
export * from './time';
3 changes: 3 additions & 0 deletions src/utils/helper/time.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export function formatDate(millis: string | number): string {
return new Date(Number(millis)).toUTCString();
}