This repository was archived by the owner on Nov 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Add some component #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subroh0508
suggested changes
Dec 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review!
I tried to check the operation, but I got an error with the following code 😭 If it works in your local environment, I would like to see the sample code.
val data: Array<Data> = arrayOf(
jsObject { name = "Mizuki Makabe"; age = 17 },
jsObject { name = "Madoka Higuchi"; age = 17 },
)
autoComplete<Data> {
attrs.options = data
attrs.getOptionLabel = { it.name }
attrs.renderInput = {
buildElements {
textField {
console.log(Object.assign(attrs, it))
Object.assign(attrs, it)
attrs.label { +"Combo box" }
attrs.variant = FormControlVariant.outlined
}
}
}
}
Clicking on it will result in an error like this.
Uncaught TypeError: Cannot read property 'focus' of null
at handleClick (webpack-internal:///../../node_modules/@material-ui/lab/esm/useAutocomplete/useAutocomplete.js:928)
at HTMLUnknownElement.callCallback (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:188)
at Object.invokeGuardedCallbackDev (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:237)
at invokeGuardedCallback (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:292)
at invokeGuardedCallbackAndCatchFirstError (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:306)
at executeDispatch (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:389)
at executeDispatchesInOrder (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:411)
at executeDispatchesAndRelease (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:3278)
at executeDispatchesAndReleaseTopLevel (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:3287)
at forEachAccumulated (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:3259)
you must use props() method for set props sorry my English is not good |
subroh0508
reviewed
Feb 21, 2021
Comment on lines
+38
to
+41
val DATA: Array<Person> = arrayOf( | ||
jsObject { name = "Mizuki Makabe"; age = 17 }, | ||
jsObject { name = "Madoka Higuchi"; age = 17 }, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍 👍
subroh0508
approved these changes
Feb 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
+AutoComplete component
+useAutoComplete hooks function
+StylesProvider componen for support jss
+some missing props
edit StyleBiulder for support static style