Skip to content

Add GlobalEgressIP CRD and associated generated code#1172

Merged
tpantelis merged 1 commit intosubmariner-io:develfrom
sridhargaddam:gnegress-v1
May 10, 2021
Merged

Add GlobalEgressIP CRD and associated generated code#1172
tpantelis merged 1 commit intosubmariner-io:develfrom
sridhargaddam:gnegress-v1

Conversation

@sridhargaddam
Copy link
Copy Markdown
Member

@sridhargaddam sridhargaddam commented Mar 2, 2021 •
edited by tpantelis
Loading

This PR adds the necessary types and includes the clientsets, informers and listers using codegenerator.

Fixes #1157

@sridhargaddam sridhargaddam mentioned this pull request Mar 2, 2021
Closed
@sridhargaddam
Copy link
Copy Markdown
Member Author

sridhargaddam commented Mar 2, 2021

@dfarrell07 included your review comments in this PR.

@sridhargaddam
Copy link
Copy Markdown
Member Author

sridhargaddam commented Mar 2, 2021

Failure in unit-tests is not related to this PR.

tpantelis
tpantelis requested changes Mar 3, 2021
View reviewed changes
@stale
Copy link
Copy Markdown

stale bot commented Mar 19, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 19, 2021
@sridhargaddam
Copy link
Copy Markdown
Member Author

sridhargaddam commented Mar 19, 2021

bump

@stale stale bot removed the wontfix This will not be worked on label Mar 19, 2021
@stale
Copy link
Copy Markdown

stale bot commented Apr 2, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 2, 2021
@tpantelis
Copy link
Copy Markdown
Contributor

tpantelis commented Apr 2, 2021

bump

@stale stale bot removed the wontfix This will not be worked on label Apr 2, 2021
@stale
Copy link
Copy Markdown

stale bot commented Apr 17, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 17, 2021
@tpantelis
Copy link
Copy Markdown
Contributor

tpantelis commented Apr 17, 2021

bump

@stale stale bot removed the wontfix This will not be worked on label Apr 17, 2021
@stale
Copy link
Copy Markdown

stale bot commented May 1, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 1, 2021
@tpantelis
Copy link
Copy Markdown
Contributor

tpantelis commented May 1, 2021

bump

@stale stale bot removed the wontfix This will not be worked on label May 1, 2021
@submariner-bot
Copy link
Copy Markdown
Contributor

submariner-bot commented May 6, 2021

🤖 Created branch: z_pr1172/sridhargaddam/gnegress-v1

tpantelis
tpantelis reviewed May 6, 2021
View reviewed changes
@tpantelis tpantelis mentioned this pull request May 6, 2021
Closed
@tpantelis tpantelis self-assigned this May 6, 2021
sridhargaddam
sridhargaddam commented May 6, 2021
View reviewed changes
sridhargaddam
sridhargaddam commented May 6, 2021
View reviewed changes
sridhargaddam
sridhargaddam commented May 6, 2021
View reviewed changes
@tpantelis tpantelis changed the title Create GlobalnetEgressIP clientset and associated items Add GlobalEgressIP CRD and associated generated code May 6, 2021
sridhargaddam
sridhargaddam commented May 7, 2021
View reviewed changes
sridhargaddam
sridhargaddam commented May 7, 2021
View reviewed changes
@sridhargaddam
Copy link
Copy Markdown
Member Author

sridhargaddam commented May 7, 2021

Thanks @tpantelis for updating the PR :)

sridhargaddam
sridhargaddam commented May 7, 2021
View reviewed changes
Copy link
Copy Markdown
Member Author

@sridhargaddam sridhargaddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some linting failures, otherwise LGTM thanks @tpantelis.

@sridhargaddam @tpantelis
Add GlobalEgressIP CRD and associated generated code
6f68186 
This PR adds the necessary types and includes the clientsets,
informers and listers using gthe code generator.

Fixes issue: submariner-io#1157

Signed-Off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
@tpantelis tpantelis merged commit a7b0766 into submariner-io:devel May 10, 2021
@submariner-bot
Copy link
Copy Markdown
Contributor

submariner-bot commented May 10, 2021

🤖 Closed branches: [z_pr1172/sridhargaddam/gnegress-v1]

@tpantelis tpantelis mentioned this pull request May 13, 2021
Merged
This was referenced Feb 27, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tpantelis tpantelis tpantelis approved these changes

@dfarrell07 dfarrell07 dfarrell07 approved these changes

@mangelajo mangelajo Awaiting requested review from mangelajo

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

@vthapar vthapar Awaiting requested review from vthapar vthapar is a code owner

Assignees

@tpantelis tpantelis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create GlobalnetEgressIP and associated objects

4 participants

@sridhargaddam @tpantelis @submariner-bot @dfarrell07