Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REQUEST: New committer rights request for dfarrell07 #2900

Closed
6 tasks done
dfarrell07 opened this issue Feb 6, 2024 · 6 comments
Closed
6 tasks done

REQUEST: New committer rights request for dfarrell07 #2900

dfarrell07 opened this issue Feb 6, 2024 · 6 comments
Assignees
@dfarrell07

Comments

@dfarrell07
Copy link
Member

dfarrell07 commented Feb 6, 2024 •
edited
Loading

GitHub Username

@dfarrell07

Code you are requesting Committer rights for

All the files required to make a release.

releases/releases/*
admiral/go.mod
admiral/go.sum
cloud-prepare/go.mod
cloud-prepare/go.sum
lighthouse/go.mod
lighthouse/go.sum
lighthouse/coredns/go.mod
lighthouse/coredns/go.sum
submariner/go.mod
submariner/go.sum
submariner-operator/api/v1alpha1/versions.go
submariner-operator/go.mod
submariner-operator/go.sum
subctl/scripts/test/system.sh
subctl/go.mod
subctl/go.sum
submariner-charts/Makefile

Requirements

Sponsors

List of required reviews to Submariner project PRs
@dfarrell07 dfarrell07 self-assigned this Feb 6, 2024
@tpantelis
Copy link
Contributor

tpantelis commented Feb 6, 2024 •
edited
Loading

+1

Let's use this to also add @aswinsuryan and @maayanf24. I pushed #2899 to start it off.

First we need to get the "Add vthapar as code owner" PRs merged in each repo to avoid conflicts. Just need another approver.

@skitt
Copy link
Member

skitt commented Feb 6, 2024

+1 from me too, for all three.

@dfarrell07
Copy link
Member Author

We could add @yboaron too?

@tpantelis
Copy link
Contributor

We could add @yboaron too?

+1

@skitt
Copy link
Member

skitt commented Feb 6, 2024

+1 for @yboaron too!

dfarrell07 added a commit to dfarrell07/releases that referenced this issue Feb 6, 2024
@dfarrell07
Add Yossi as committer to releases/*
df6d99d 
Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/releases that referenced this issue Feb 6, 2024
@dfarrell07
Add Yossi and Maayan as committers to releases/*
4ae1a22 
Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
@dfarrell07 dfarrell07 mentioned this issue Feb 6, 2024
Merged
dfarrell07 added a commit to dfarrell07/admiral that referenced this issue Feb 6, 2024
@dfarrell07
Add committers to go.mod and go.sum
aed1e78 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
@dfarrell07 dfarrell07 mentioned this issue Feb 6, 2024
Merged
tpantelis pushed a commit to submariner-io/releases that referenced this issue Feb 6, 2024
@dfarrell07 @tpantelis
Add Yossi and Maayan as committers to releases/*
3b329f0 
Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
tpantelis pushed a commit to submariner-io/admiral that referenced this issue Feb 6, 2024
@dfarrell07 @tpantelis
Add committers to go.mod and go.sum
044ec55 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/cloud-prepare that referenced this issue Feb 6, 2024
@dfarrell07
Add committers to go.mod and go.sum
5efa8df 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
@dfarrell07 dfarrell07 mentioned this issue Feb 6, 2024
Merged
dfarrell07 added a commit to dfarrell07/lighthouse that referenced this issue Feb 6, 2024
@dfarrell07
Add committers to go.mod and go.sum
7265111 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
@dfarrell07 dfarrell07 mentioned this issue Feb 6, 2024
Merged
dfarrell07 added a commit to dfarrell07/submariner that referenced this issue Feb 6, 2024
@dfarrell07
Add Yossi as committer to go.mod and go.sum
8f32232 
To allow more folks to help make releases.

Relates-to: submariner-io#2900
Signed-off-by: Daniel Farrell <[email protected]>
@dfarrell07 dfarrell07 mentioned this issue Feb 6, 2024
Merged
tpantelis pushed a commit to submariner-io/cloud-prepare that referenced this issue Feb 6, 2024
@dfarrell07 @tpantelis
Add committers to go.mod and go.sum
ed93471 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/submariner-operator that referenced this issue Feb 6, 2024
@dfarrell07
Add committers to release-related files
352742f 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
@dfarrell07 dfarrell07 mentioned this issue Feb 6, 2024
Merged
dfarrell07 added a commit to dfarrell07/subctl that referenced this issue Feb 6, 2024
@dfarrell07
Add committers to release-related files
b4ed892 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
@dfarrell07 dfarrell07 mentioned this issue Feb 6, 2024
Merged
dfarrell07 added a commit to dfarrell07/submariner-charts that referenced this issue Feb 6, 2024
@dfarrell07
Add committers to release-related files
01ca995 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/submariner-charts that referenced this issue Feb 6, 2024
@dfarrell07
Add committers to Makefile
338e861 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
@dfarrell07 dfarrell07 mentioned this issue Feb 6, 2024
Merged
skitt pushed a commit to submariner-io/lighthouse that referenced this issue Feb 6, 2024
@dfarrell07 @skitt
Add committers to go.mod and go.sum
e0c06a3 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
tpantelis pushed a commit to submariner-io/submariner-operator that referenced this issue Feb 6, 2024
@dfarrell07 @tpantelis
Add committers to release-related files
703db3a 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
skitt pushed a commit that referenced this issue Feb 6, 2024
@dfarrell07 @skitt
Add Yossi as committer to go.mod and go.sum
941bc21 
To allow more folks to help make releases.

Relates-to: #2900
Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07 added a commit to dfarrell07/submariner-charts that referenced this issue Feb 8, 2024
@dfarrell07
Add committers to Makefile
ffc986c 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit e416a2d)
dfarrell07 added a commit to dfarrell07/submariner-charts that referenced this issue Feb 8, 2024
@dfarrell07
Add committers to Makefile
e2a8002 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit e416a2d)
dfarrell07 added a commit to dfarrell07/submariner-charts that referenced this issue Feb 8, 2024
@dfarrell07
Add committers to Makefile
b0b1abc 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit e416a2d)
dfarrell07 added a commit to dfarrell07/submariner-operator that referenced this issue Feb 8, 2024
@dfarrell07
Add committers to release-related files
611f354 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit 703db3a)
dfarrell07 added a commit to dfarrell07/submariner-operator that referenced this issue Feb 8, 2024
@dfarrell07
Add committers to release-related files
2aedaa0 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit 703db3a)
dfarrell07 added a commit to dfarrell07/submariner-operator that referenced this issue Feb 8, 2024
@dfarrell07
Add committers to release-related files
0dd7238 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit 703db3a)
Jaanki pushed a commit to submariner-io/subctl that referenced this issue Feb 8, 2024
@dfarrell07 @Jaanki
Add committers to release-related files
743ed16 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
tpantelis pushed a commit to submariner-io/releases that referenced this issue Feb 8, 2024
@dfarrell07 @tpantelis
Add Yossi and Maayan as committers to releases/*
ca6a996 
Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit 3b329f0)
tpantelis pushed a commit to submariner-io/releases that referenced this issue Feb 8, 2024
@dfarrell07 @tpantelis
Add Yossi and Maayan as committers to releases/*
b27ab61 
Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit 3b329f0)
tpantelis pushed a commit to submariner-io/releases that referenced this issue Feb 8, 2024
@dfarrell07 @tpantelis
Add Yossi and Maayan as committers to releases/*
054b043 
Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit 3b329f0)
tpantelis pushed a commit to submariner-io/admiral that referenced this issue Feb 8, 2024
@dfarrell07 @tpantelis
Add committers to go.mod and go.sum
2e177e2 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit 044ec55)
tpantelis pushed a commit to submariner-io/admiral that referenced this issue Feb 8, 2024
@dfarrell07 @tpantelis
Add committers to go.mod and go.sum
e8ed980 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit 044ec55)
tpantelis pushed a commit to submariner-io/admiral that referenced this issue Feb 8, 2024
@dfarrell07 @tpantelis
Add committers to go.mod and go.sum
b9ec504 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit 044ec55)
tpantelis pushed a commit to submariner-io/lighthouse that referenced this issue Feb 8, 2024
@dfarrell07 @tpantelis
Add committers to go.mod and go.sum
62316c1 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit e0c06a3)
tpantelis pushed a commit to submariner-io/lighthouse that referenced this issue Feb 8, 2024
@dfarrell07 @tpantelis
Add committers to go.mod and go.sum
e56839c 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit e0c06a3)
tpantelis pushed a commit to submariner-io/submariner-operator that referenced this issue Feb 8, 2024
@dfarrell07 @tpantelis
Add committers to release-related files
fe7ee9a 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit 703db3a)
tpantelis pushed a commit to submariner-io/lighthouse that referenced this issue Feb 8, 2024
@dfarrell07 @tpantelis
Add committers to go.mod and go.sum
c9b3f14 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit e0c06a3)
tpantelis pushed a commit to submariner-io/submariner-charts that referenced this issue Feb 9, 2024
@dfarrell07 @tpantelis
Add committers to Makefile
f25c181 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit e416a2d)
tpantelis pushed a commit to submariner-io/submariner-charts that referenced this issue Feb 9, 2024
@dfarrell07 @tpantelis
Add committers to Makefile
222123a 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit e416a2d)
tpantelis pushed a commit to submariner-io/submariner-operator that referenced this issue Feb 9, 2024
@dfarrell07 @tpantelis
Add committers to release-related files
809c79f 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit 703db3a)
tpantelis pushed a commit to submariner-io/submariner-charts that referenced this issue Feb 9, 2024
@dfarrell07 @tpantelis
Add committers to Makefile
54ebb40 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit e416a2d)
tpantelis pushed a commit that referenced this issue Feb 9, 2024
@dfarrell07 @tpantelis
Add Yossi as committer to go.mod and go.sum
a4ec6fe 
To allow more folks to help make releases.

Relates-to: #2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit 941bc21)
tpantelis pushed a commit that referenced this issue Feb 9, 2024
@dfarrell07 @tpantelis
Add Yossi as committer to go.mod and go.sum
a88cae0 
To allow more folks to help make releases.

Relates-to: #2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit 941bc21)
tpantelis pushed a commit that referenced this issue Feb 9, 2024
@dfarrell07 @tpantelis
Add Yossi as committer to go.mod and go.sum
e30eae3 
To allow more folks to help make releases.

Relates-to: #2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit 941bc21)
tpantelis pushed a commit to submariner-io/cloud-prepare that referenced this issue Feb 9, 2024
@dfarrell07 @tpantelis
Add committers to go.mod and go.sum
11e0a74 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit ed93471)
tpantelis pushed a commit to submariner-io/cloud-prepare that referenced this issue Feb 9, 2024
@dfarrell07 @tpantelis
Add committers to go.mod and go.sum
08b40b1 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit ed93471)
tpantelis pushed a commit to submariner-io/cloud-prepare that referenced this issue Feb 9, 2024
@dfarrell07 @tpantelis
Add committers to go.mod and go.sum
a71562c 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit ed93471)
tpantelis pushed a commit to submariner-io/submariner-operator that referenced this issue Feb 9, 2024
@dfarrell07 @tpantelis
Add committers to release-related files
4f3e623 
To allow more folks to help make releases.

Relates-to: submariner-io/submariner#2900
Signed-off-by: Daniel Farrell <[email protected]>
(cherry picked from commit 703db3a)
@dfarrell07
Copy link
Member Author

I think all the PRs and backports have been merged. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfarrell07 dfarrell07

Labels
None yet
Projects
No open projects
Submariner 0.18
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dfarrell07 @skitt @tpantelis