Remove outdated note about Globalnet and headless services#635
Merged
nyechiel merged 3 commits intosubmariner-io:develfrom Dec 29, 2021
Merged
Remove outdated note about Globalnet and headless services#635nyechiel merged 3 commits intosubmariner-io:develfrom
nyechiel merged 3 commits intosubmariner-io:develfrom
Conversation
Signed-off-by: nyechiel <nyechiel@redhat.com>
nyechiel
requested review from
Oats87,
dfarrell07,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr635/nyechiel/kind-headless |
|
✔️ Deploy Preview for elated-bell-2913d9 ready! 🔨 Explore the source changes: c6f86b4 🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-bell-2913d9/deploys/61cc7ec23518ee0008eb3a11 😎 Browse the preview: https://deploy-preview-635--elated-bell-2913d9.netlify.app |
sridhargaddam
approved these changes
Dec 27, 2021
Member
sridhargaddam
left a comment
sridhargaddam
left a comment
There was a problem hiding this comment.
Thanks for fixing it @nyechiel
Jaanki
approved these changes
Dec 29, 2021
maayanf24
approved these changes
Dec 29, 2021
|
🤖 Closed branches: [z_pr635/nyechiel/kind-headless] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://submariner.io/getting-started/quickstart/kind/ currently has a note that says "Headless Services can only be exported on non-Globalnet deployments" which is no longer true with the recent implementation of Globalnet (Submariner 0.10 and above) as described here.
Signed-off-by: nyechiel nyechiel@redhat.com