Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic cluster CIDR discovery should check for pod command Arg #3180

Closed
tpantelis opened this issue Aug 2, 2024 · 0 comments · Fixed by #3219
Closed

Generic cluster CIDR discovery should check for pod command Arg #3180

tpantelis opened this issue Aug 2, 2024 · 0 comments · Fixed by #3219
Assignees
@tpantelis
Labels
bug Something isn't working priority:medium

Comments

@tpantelis
Copy link
Contributor

On RKE2, it was observed that the cluster CIDR was discovered as 10.42.0.0/24 instead of 10.42.0.0/16. The CNI was calico so it uses the generic cluster CIDR discovery. This finds the pod labeled with component=kube-controller-manager and extracts the --cluster-cidr arg from the container’s Command field. However in this case --cluster-cidr was specified in the Args field:

Containers:
  kube-controller-manager:
    ...
    Command:
      kube-controller-manager
    Args:
      ...
      --cluster-cidr=10.42.0.0/16

We need to check for both.
@tpantelis tpantelis added the bug Something isn't working label Aug 2, 2024
@tpantelis tpantelis self-assigned this Aug 2, 2024
tpantelis added a commit to tpantelis/submariner-operator that referenced this issue Sep 11, 2024
@tpantelis
Check for pod command Arg in pod CIDR discovery
16f8617 
...in addition to the command itself

Fixes submariner-io#3180

Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis tpantelis mentioned this issue Sep 11, 2024
Merged
tpantelis added a commit to tpantelis/submariner-operator that referenced this issue Sep 12, 2024
@tpantelis
Check for pod command Arg in pod CIDR discovery
56b2ace 
...in addition to the command itself

Fixes submariner-io#3180

Signed-off-by: Tom Pantelis <[email protected]>
tpantelis added a commit to tpantelis/submariner-operator that referenced this issue Sep 12, 2024
@tpantelis
Check for pod command Arg in pod CIDR discovery
af26c88 
...in addition to the command itself

Fixes submariner-io#3180

Signed-off-by: Tom Pantelis <[email protected]>
tpantelis added a commit that referenced this issue Sep 17, 2024
@tpantelis
Check for pod command Arg in pod CIDR discovery
289b6f6 
...in addition to the command itself

Fixes #3180

Signed-off-by: Tom Pantelis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpantelis tpantelis

Labels
bug Something isn't working priority:medium
Projects
Submariner 0.19
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for pod command Arg in pod CIDR discovery tpantelis/submariner-operator
2 participants
@dfarrell07 @tpantelis