Automated backport of #1657: Use identifying labels for lookup of EPS on service EPS #1660
+81
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
aswinsuryan,
dfarrell07,
maayanf24,
Oats87,
skitt,
sridhargaddam,
vthapar and
yboaron
as code owners
|
🤖 Created branch: z_pr1660/tpantelis/automated-backport-of-#1657-upstream-release-0.18 |
aswinsuryan
approved these changes
Oct 7, 2024
dfarrell07
approved these changes
Oct 7, 2024
skitt
approved these changes
Oct 8, 2024
|
This PR/issue depends on: |
...instead of all labels otherwise, on update to the service labels, the existing EPS is not found resulting in a new one created. Related to submariner-io#1646 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
automated-backport-of-#1657-upstream-release-0.18
branch
from
9d43c98
to
5a5de54
Compare
|
🤖 Closed branches: [z_pr1660/tpantelis/automated-backport-of-#1657-upstream-release-0.18] |
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Oct 8, 2024
submariner-io/lighthouse#1660 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Oct 8, 2024
submariner-io/lighthouse#1660 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Oct 8, 2024
submariner-io/lighthouse#1660 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Oct 8, 2024
submariner-io/lighthouse#1660 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Oct 8, 2024
submariner-io/lighthouse#1660 Signed-off-by: Tom Pantelis <[email protected]>
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1657 on release-0.18.
#1657: Use identifying labels for lookup of EPS on service EPS
For details on the backport process, see the backport requests page.
Depends on submariner-io/admiral#1005