Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use informer to retry failed resources due to missing namespace #913

Merged
merged 2 commits into from
May 16, 2024

Conversation

tpantelis
Copy link
Contributor

@tpantelis tpantelis commented May 13, 2024

...rather than exponential re-queuing which is problematic at scale. The user can specify a SharedInformer that is used to requeue resources that had previously failed when a missing namespace is later created.

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr913/tpantelis/syncer_ns_informer

aswinsuryan
aswinsuryan previously approved these changes May 13, 2024
@aswinsuryan aswinsuryan dismissed their stale review May 13, 2024 17:05

there seems to UT failures

@tpantelis tpantelis force-pushed the syncer_ns_informer branch 3 times, most recently from 5977f6c to 0320f16 Compare May 14, 2024 00:39
@tpantelis tpantelis changed the title Use informer to retry resources that initially failed due to missing … Use informer to retry failed resources due to missing namespace May 14, 2024
@tpantelis tpantelis requested a review from dfarrell07 May 14, 2024 12:15
...rather than exponential requeuing which is problematic at scale.
The user can specify a SharedInformer that is used to requeue resources
that had previously failed when a missing namespace is later created.

Signed-off-by: Tom Pantelis <[email protected]>
@skitt skitt merged commit cdbf402 into submariner-io:devel May 16, 2024
16 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr913/tpantelis/syncer_ns_informer]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants