Make IsMissingNamespaceErr return bool only, split func #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice I find IsMissingNamespaceErr cumbersome to use, since it always requires storing its result in variables even though common usage patterns involve if statements. Splitting it into two functions this. The repeated processing shouldn't be an issue in practice, especially since (current) uses of this function only happen once in the lifetime of a given program. Signed-off-by: Stephen Kitt <[email protected]>
skitt
requested review from
Oats87,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr910/skitt/split-missing-namespace-error |
This was referenced May 7, 2024
tpantelis
approved these changes
May 7, 2024
dfarrell07
approved these changes
May 7, 2024
|
🤖 Closed branches: [z_pr910/skitt/split-missing-namespace-error] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In practice I find IsMissingNamespaceErr cumbersome to use, since it always requires storing its result in variables even though common usage patterns involve if statements.
Splitting it into two functions this. The repeated processing shouldn't be an issue in practice, especially since (current) uses of this function only happen once in the lifetime of a given program.