Fix issues with diagnostics panel toggling on save #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the sake of reviewers decided to revert introduction of |
|
Tested this. Works fine if there is one session that publishes diagnostics. ✔️ Doesn't work if there are 2 sessions that publish diagnostics. (for example LSP-pyright and diagnostics-ls). ⚔️ I noticed that if there are multiple sessions in the view, Gif
nor will the panel close if there are no diagnostics: Gif
Diagnostics-ls configuration{
"clients": {
"diagnostic-ls": {
"enabled": true,
"command": [
"diagnostic-languageserver",
"--stdio",
"--log-level",
"2"
],
"selector": "source.python",
"initializationOptions": {
"linters": {
"cspell": {
"command": "cspell",
"debounce": 100,
"args": [
"%filepath"
],
"sourceName": "cspell",
"formatLines": 1,
"formatPattern": [
// the error message looks like this:
// /home/predrag/.config/sublime-text/Packages/Sone/index.py:1:1 - Unknown word (funer)
".*?:(\\d+):(\\d+)\\s*-\\s*(.*)",
{
"line": 1,
"column": 2,
"message": 3,
}
],
},
// "flake8": {
// "command": "flake8",
// "debounce": 100,
// "args": [
// "--format",
// "%(row)d,%(col)d,%(code).1s,%(text)s [%(code)s]",
// "-"
// ],
// "sourceName": "flake8",
// "formatLines": 1,
// "formatPattern": [
// "(\\d+),(\\d+),()([A-Z]),(.*)",
// {
// "line": 1,
// "column": 2,
// "security": 3, // Match a zero-length group so everything can be classified as a Warning rather than Error
// "message": 5,
// }
// ],
// "securities": {
// "": "warning",
// },
// },
},
"formatters": {},
"filetypes": {
// "python": "cspell",
// "python": "cspell",
"python": "flake8",
},
},
},
}
} |
I have been testing with 2 active sessions (pyright and pylsp). Maybe there is something special about |
|
Here are the logs when:
Here are the logs when:
apparetnly diagnostic-ls never publishes the diagnostics. |
|
I think I have misunderstood a bit how diagnostics version works. Server can report outdated diagnostics for given version and then update them later for the same version. That messes up with the logic I've applied here... It's then pretty hard to fix reliably so that the panel only opens/closes after save rather than whenever diagnostics change. |
* main: Ensure "Source Actions..." request includes the "source" kind (#2064)
|
Implemented new approach that should work better. As long as view's |
predragnikolic
approved these changes
Sep 25, 2022
This was referenced Sep 26, 2022
rchl
added a commit
that referenced
this pull request
Sep 27, 2022
* main: Fix issues with diagnostics panel toggling on save (#2063) Request color presentations when clicking on a color box (#2065) Import new imports like NotRequired from "typing" Ensure "Source Actions..." request includes the "source" kind (#2064) refactor(types): Mark properties with NotRequired (#2062) Add template variable `$text_document_position` in execute command (#2061) Only update content of diagnostics panel when visible (#2054) Remove Range class and rename RangeLsp to Range (#2058)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing or hiding diagnostics panel on save was generally broken.
Changes:
The code for showing was in
SessionBufferand the code for hiding was inDocumentSyncListener. Now everything is inDocumentSyncListener.Removed
AbstractViewListener.diagnostics_asyncinterface as it didn't need to be public (not currently used by anything outside ofDocumentSyncListener).DiagnosticsManagerclass renamed toDiagnosticsStoragesince it wasn't really a manager but just glorified session diagnostics storage.Created actualREVERTEDDiagnosticsManagerthat is an per-window interface to access diagnostics for all sessions. It's not essential currently but I think it's cleaner to have it and we could move more stuff there in the future.SessionBuffer.total_errorsandSessionBuffer.total_warningsremoved as those were unused.Also drive-by fix to fix regression introduced by Only update content of diagnostics panel when visible #2054 where
show_diagnostics_count_in_view_statusstopped working since the code to update the status was running fromupdate_diagnostics_panel_asyncwhich was no longer triggered.