Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scala] Various stateful bailout bugs #756

Merged
merged 2 commits into from
Dec 23, 2016

Conversation

djspiewak
Copy link
Contributor

Random best practice that's worth documenting somewhere…  When you have any sort of stateful context chain, make sure each link in the chain ends with the following:

- match: (?=\S)
  pop: true

Anything you don't recognize, you should just bail on.

Another best practice: don't accidentally match on double word boundary by having a trailing pipe character.

@FichteFoll
Copy link
Collaborator

FichteFoll commented Dec 23, 2016

Another best practice: don't accidentally match on double word boundary by having a trailing pipe character.

I, too, have been guilty of this.

@wbond
Copy link
Member

wbond commented Dec 23, 2016

I agree that some best practices would be good to add. I've opened #757 where you can write things down. I'll write them up and add to the docs at some point.

@wbond wbond merged commit 7449bbd into sublimehq:master Dec 23, 2016
@djspiewak djspiewak deleted the bug/next-line-with branch December 24, 2016 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants