Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[meta] run syntax_tests in parallel on dev and (optionally) stable Builds #3090

Merged
merged 8 commits into from
Oct 19, 2021
Merged

[meta] run syntax_tests in parallel on dev and (optionally) stable Builds #3090

merged 8 commits into from
Oct 19, 2021

Conversation

jrappen
Copy link
Contributor

@jrappen jrappen commented Oct 13, 2021 •
edited
Loading

  • change workflow name to mirror workflow file name
  • run workflow matrix with parallel tests with syntax_tests binaries from latest stable & dev channel builds
    • optional tests with stable Build are allowed to fail as there might be newer features in dev Builds only
  • add ability to trigger workflow via (manual) dispatch from the workflow run history page
  • update labels of workflow jobs and their steps
    • merged some steps and relabeled them for better readability of workflow run overview

Co-authored-by: michaelblyons [email protected]
Co-authored-by: Keith Hall [email protected]

@jrappen
[meta] update github action workflow
946437f 
to run parallel tests with latest stable & dev channel syntax_tests
binary
keith-hall
keith-hall previously approved these changes Oct 14, 2021
View reviewed changes
keith-hall
keith-hall previously approved these changes Oct 15, 2021
View reviewed changes
michaelblyons
michaelblyons previously approved these changes Oct 16, 2021
View reviewed changes
@jrappen jrappen dismissed stale reviews from michaelblyons and keith-hall via 36f3b00 October 18, 2021 00:25
@jrappen
Copy link
Contributor Author

jrappen commented Oct 18, 2021 •
edited
Loading

Adds ability to run workflow manually from button on GitHub at https://github.com/sublimehq/Packages/actions/workflows/ci.yml. Will look like this (similar):

image

@jrappen
Copy link
Contributor Author

jrappen commented Oct 18, 2021 •
edited
Loading

Also labels should be clearer for workflow jobs after selecting a run at https://github.com/sublimehq/Packages/actions/. Compare (similar):

image

... and when expanding checks in a PR. Compare (similar):

image

@michaelblyons
Copy link
Collaborator

Apologies for ignorant question: Can the matrix be a dict like { Dev: 4118, Stable: 4113 }, and then name of run like "Run syntax_tests on Dev Build 4118" ? If not, this is still good. I just wanted to check.

@jrappen
Copy link
Contributor Author

jrappen commented Oct 18, 2021 •
edited
Loading

I don't know, will have to check.

@jrappen
Copy link
Contributor Author

jrappen commented Oct 18, 2021 •
edited
Loading

Looking at https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idstrategymatrix it seems possible to set variables with matrix.include for a list of dictionaries.

@jrappen @michaelblyons
[meta] improve labeling of workflow
f19ca00 
via `matrix.include`

Co-authored-by: michaelblyons <[email protected]>
@jrappen
Copy link
Contributor Author

jrappen commented Oct 18, 2021

Improved labeling now results in:

image

@jrappen
[meta] merge steps in workflow for:
7f1f7a9 
- creating subdir
- moving root dirs into it
michaelblyons
michaelblyons previously approved these changes Oct 18, 2021
View reviewed changes
keith-hall
keith-hall previously approved these changes Oct 18, 2021
View reviewed changes
@keith-hall
Copy link
Collaborator

Is it possible to make the stable check optional (i.e. allow PRs to still be merged if it fails)? Otherwise we won't be able to use features not yet in a stable build...

@jrappen jrappen dismissed stale reviews from keith-hall and michaelblyons via 260d733 October 18, 2021 03:32
@keith-hall
Copy link
Collaborator

Nice work, looks great!

@jrappen jrappen changed the title [meta] update github action workflow [meta] run syntax_tests in parallel on dev and (optionally) stable Builds Oct 18, 2021
@BenjaminSchaaf BenjaminSchaaf merged commit 258ace9 into sublimehq:master Oct 19, 2021
@jrappen jrappen deleted the fix-github-action branch October 19, 2021 01:45
@michaelblyons
Copy link
Collaborator

A couple PRs in, I like this a lot.

mitranim pushed a commit to mitranim/Packages that referenced this pull request Mar 25, 2022
@jrappen @michaelblyons
@keith-hall @mitranim
[meta] run syntax_tests in parallel on dev and (optionally) `stab…
bc8bbb6 
…le` Builds (sublimehq#3090)

* [meta] update github action workflow

to run parallel tests with latest stable & dev channel syntax_tests
binary

* [meta] use Build 4118 test binary

* [meta] update displayed names of workflow jobs

* [meta] minor readability improvements of workflow

* [meta] add ability to run workflow on dispatch

This adds a button to workflow history page at:
<https://github.com/sublimehq/Packages/actions/workflows/ci.yml>

* [meta] improve labeling of workflow

via `matrix.include`

Co-authored-by: michaelblyons <[email protected]>

* [meta] merge steps in workflow for:

- creating subdir
- moving root dirs into it

* [meta] optionally run workflow on stable builds

Co-authored-by: Keith Hall <[email protected]>

Co-authored-by: michaelblyons <[email protected]>
Co-authored-by: Keith Hall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UltraInstinct05 UltraInstinct05 UltraInstinct05 left review comments

@keith-hall keith-hall keith-hall approved these changes

@BenjaminSchaaf BenjaminSchaaf BenjaminSchaaf approved these changes

@michaelblyons michaelblyons michaelblyons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrappen @michaelblyons @keith-hall @BenjaminSchaaf @UltraInstinct05