[JavaScript] Support private property accessors. #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
What about private methods? class SomeClass {
#somePrivateMethod(data) {
return "foo";
}
}
I'm seeing this at the company I work at right now. |
|
Fixed in #2476. Thanks for reporting. |
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1949.
The original implementation in #1292 did not properly support private property accessors, but in most cases they worked almost-correctly by coincidence. #1949 identifies a case in which they do not work at all. This PR implements them correctly.
Private fields are part of the TC39 class fields proposal, which is Stage 3.