Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent background? #1

Closed
Blankeos opened this issue Oct 18, 2024 · 10 comments
Closed

Transparent background? #1

Blankeos opened this issue Oct 18, 2024 · 10 comments

Comments

@Blankeos
Copy link

Anyway to do it? Cool fork btw!

@subframe7536
Copy link
Owner

Just implement it following be5invis/vscode-custom-css#236, and I havent tried it yet, cause I have no need for it.

You can setup custom-ui-style.electron just like apc to have a try

@Blankeos
Copy link
Author

Blankeos commented Oct 19, 2024

Thanks for the reply! Yeah I have tried:

"custom-ui-style.electron": {
   "transparent": true,
   "frame": false
}

No luck unfortunately. Here's the closest Reddit post of someone who's done it in APC I think (if you wanna give it a go as well): https://www.reddit.com/r/vscode/comments/19exkmj/mac_os_style_semi_transparent_sidebar/

@subframe7536
Copy link
Owner

Try to fix it using vscode-vibrancy-continued's logic

Released in v0.2.1

@hologerry
Copy link

Try to fix it using vscode-vibrancy-continued's logic

Released in v0.2.1

I tested this version in VSCode insiders, but not work.

@subframe7536
Copy link
Owner

Well, I have no bandwidth and I'm not really feeling up to fixing this issue lately.

So, PR welcome 👋

@subframe7536 subframe7536 added the PR welcome Extra attention is needed label Oct 19, 2024
@Blankeos
Copy link
Author

Blankeos commented Oct 19, 2024

Okay wait lol guys. It does actually work. Actually... I'm not sure which worked:

  1. This extension.
  2. Or this monkey-patching solution. (this is basically what the extension does automatically) - I noticed that after I added my configs with @subframe7536 's extension, and open code /Applications/Visual\ Studio\ Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js, I do see the changes though so the Monkey patch might not be needed, just change it in the config.
image

HERE'S THE KICKER, I found that, it does reflect the change after I restart the whole computer! Not "restarting" or "reloading" VSCode (I just slept and woke up again lol). Not sure how to simulate a whole restart without actually restarting. frame: false does not seem to work though.

Also for the vibrancy (blurriness of the window, it differs per OS, I'm on a Mac), can refer to this: https://www.electronjs.org/docs/latest/api/browser-window#winsetvibrancytype-macos. Or just refer to that page for all the other settings on electron.

It's beautiful:

image

Version:
image

@subframe7536
Copy link
Owner

HERE'S THE KICKER, I found that, it does reflect the change after I restart the whole computer! Not "restarting" or "reloading" VSCode (I just slept and woke up again lol). Not sure how to simulate a whole restart without actually restarting. frame: false does not seem to work though.

So, all the need to make it effect is just press CMD + Q ? I will add some tips in the Restart notification

@Blankeos
Copy link
Author

Blankeos commented Oct 19, 2024

CMD + Q doesn't work unfortunately. A whole restart seems to be needed to see the changes.

Wait lol scratch that. It does work. Apparently "opacity" only works and CMD + Q does work. I can't get vibrancy to work at all.

@Blankeos
Copy link
Author

Anyway closing this since transparency is achieved. Vibrancy not yet though.

@subframe7536 subframe7536 removed the PR welcome Extra attention is needed label Oct 23, 2024
@CnsMaple
Copy link

@Blankeos hello, Can you share your theme and icon theme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants