Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement interpreter with variable cache and invalidation #35

Merged
merged 12 commits into from
Oct 16, 2019

Conversation

yanchith
Copy link
Member

This is the first iteration of our Rooty-Lang interpreter. What's
missing:

  • The ability to pause and resume the interpreter
  • Iterative funcs a.k.a. Generators

Be aware that there is the barest amount of program
verification implemented, and that is mostly runtime. Compile time
verification is yet to come. Invalid programs may crash the
interpreter.

The interpreter is integrated into the editor with InterpreterServer,
which works very similarly to what the Importer worker does.

This is the first iteration of our Rooty-Lang interpreter. What's
missing:

- The ability to pause and resume the interpreter
- Iterative funcs a.k.a. Generators

Be aware that there is the barest amount of program
verification implemented, and that is mostly runtime. Compile time
verification is yet to come. Invalid programs may crash the
interpreter.

The interpreter is integrated into the editor with `InterpreterServer`,
which works very similarly to what the Importer worker does.
Copy link
Collaborator

@ondrowan ondrowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good overall, but there are couple of things to be addressed before we can merge it. I hope I haven't half arsed any part of it, but just to be sure, expect that I find some new things on the next sweep.

src/geometry.rs Outdated Show resolved Hide resolved
src/interpreter_funcs.rs Outdated Show resolved Hide resolved
src/interpreter_server.rs Show resolved Hide resolved
src/interpreter_server.rs Outdated Show resolved Hide resolved
src/interpreter_server.rs Outdated Show resolved Hide resolved
src/interpreter/mod.rs Show resolved Hide resolved
src/interpreter/func.rs Show resolved Hide resolved
src/interpreter/func.rs Outdated Show resolved Hide resolved
src/interpreter/func.rs Outdated Show resolved Hide resolved
src/interpreter/func.rs Outdated Show resolved Hide resolved
@yanchith
Copy link
Member Author

@ondrowan I think I addressed or answered most of your points, please have another look and let me know your decision on the few points I asked questions about.

@yanchith yanchith merged commit 58721aa into master Oct 16, 2019
@yanchith yanchith deleted the interpreter branch October 16, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants