Moved complex overloads for mac to inline from cpp. #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sehlingdorf
approved these changes
Mar 27, 2019
TobiKattmann
approved these changes
Mar 27, 2019
There was a problem hiding this comment.
Hi,
as it is 30 lines of copied code which only affects Apple Os's and fixes your compile error... LGTM.
Although the ad_structure.cpp should contain the same code after all preprocessor statements (#include etc) are executed, right? Did you look at that by any chance with the -E (for gnu, maybe different for LLVM) compiler flag. If not, then I guess it is better to not waist time on that.
Best regards, Tobi
(Sorry used another account before without noticing)
|
Seems like a quick fix. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
The latest llvm version on mac throws a compile error due to not being able to find some overloaded functions for complex numbers. Moving the overloads from the cpp file to the inline file appears to fix the linkage issue.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
N/A
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.