Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message when FLUID_MIXTURE is used with KIND_SCALAR_MODEL = NONE #2345

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Cristopher-Morales
Copy link
Contributor

Proposed Changes

This pull request restricts the use of the FLUID_MIXTURE model only when the KIND_SCALAR_MODEL is SPECIES_TRANSPORT.

Related Work

Reported in CDF-Online
https://www.cfd-online.com/Forums/su2/257519-kind_scalar_model-mixture.html

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [ x] I am submitting my contribution to the develop branch.
  • [ x] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • [ x] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@Cristopher-Morales Cristopher-Morales merged commit ab5cfb7 into develop Aug 28, 2024
35 of 37 checks passed
@Cristopher-Morales Cristopher-Morales deleted the feature_bug_fluid_mixture branch August 28, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants