-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Velocity volume output for compressible flow solvers #2077
Conversation
Added Velocity output, since I am interested in that and adding it only in the config just gets ignored and no output happens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to SU2. You need to add these variables to the "PRIMITIVE" group, there is a comment // Primitive variables
.
Look also for SetVolumeOutputValue("PRESSURE"
because for each variable you need to add it and then set its value.
Please make the same change in CNEMOCompOutput.cpp
And add yourself to AUTHORS.md
Added Velocity Volume Output
Added Velocity Output
Hi, thank you for the warm welcome. I added the changes and hope they are sufficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, you are still missing the part of the code that sets the output value, AddVolumeOutput only adds the name.
Look for SetVolumeOutputValue in the files you changed, should be very close.
I've added SetVolumeOutputValue now. Thank you for being patient and letting me make mistakes. |
Hi! Just out of curiosity, if you're interested in just the velocity and not the momentum, why not just divide the momentum vector by the density during postprocessing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you retrieve the velocity from the Primitive
vector stored in the CVariable
classes, not the Solution
vector.
There are several reasons why:
|
Disclaimer
This is my first ever contribution to any GitHub project. Please give feedback on what I can Improve if I haven't done something that is expected of me.
Proposed Changes
Added Velocity output, since I am interested in that and adding it only in the config just gets ignored and no output happens
Related Work
PR Checklist